This is one of the most useful Military Policy in the entire game, hands down! The process of upgrading your military units is constant, going throughout the entire game; and all upgrades cost Gold. After the Medieval Era they start costing quite a bit of it! And Professional Army cuts these costs in half, automatically saving you this amount of Gold! I don't need to point out the benefit of upgrading units at half cost, especially when the normal cost is 300+!
The way to use this Policy is: you gather your Gold (using other permanent gold-saving Policies in the meantime, such as Conscription), you develop your tech, and when you're ready you slot Professional Army and upgrade as many units as you can for the several turns you will have the Policy. Then slot back the money-saving Policy. Rinse and repeat as necessary. For militaristic civilizations with lots of units this is especially useful, as they will both spend huge amounts of Gold to maintain their army and to upgrade it - so, any savings are very welcome!
Of course, sometimes there will be emergencies, such as when a neighbor declares a Surprise War and you find yourself with an outdated army. In such cases you might want to upgrade several crucial units right away, without waiting to slot Professional Army.
Civilopedia Entry Edit
In the early medieval period, serfs and villeins formed the bulk of the armies; barely trained and ill-equipped, other than sheer numbers, they were pretty useless in battle. The idea of a state-maintained “professional” army had faded – as so much else did – with the Roman Empire (although China still had one). But as various nations coalesced out of the ruins, kings began to supplement their mobs drawn from feudal lords with paid professionals. These soldiers were usually housed in barracks and segregated from the civilian population to minimize friction, and the king provided their food, weapons, clothes, and training. They were (almost) always more effective than the amateurs.